Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Don't abort registering blocks when a missing block file is found. #41122

Merged
merged 2 commits into from
May 19, 2022
Merged

Blocks: Don't abort registering blocks when a missing block file is found. #41122

merged 2 commits into from
May 19, 2022

Conversation

dd32
Copy link
Member

@dd32 dd32 commented May 18, 2022

Fixes #41121

What?

Why?

How?

Testing Instructions

Screenshots or screencast

@Mamaduka Mamaduka requested a review from gziolo May 18, 2022 06:40
@gziolo gziolo added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Feature] Blocks Overall functionality of blocks labels May 18, 2022
Mamaduka
Mamaduka approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dd32.

@Mamaduka Mamaduka merged commit 97474fa into trunk May 19, 2022
@Mamaduka Mamaduka deleted the patch/41121 branch May 19, 2022 16:13
@github-actions github-actions bot added this to the Gutenberg 13.4 milestone May 19, 2022
@Mamaduka Mamaduka mentioned this pull request May 19, 2022
Closed
@andrewstaffell andrewstaffell mentioned this pull request May 19, 2022
Closed
chad1008 pushed a commit that referenced this pull request May 19, 2022
@dd32 @chad1008
Blocks: Don't abort registering blocks when a missing block file is f…
7efbbea 
…ound. (#41122)

* Don't abort registering blocks when a missing block file is found.
* Blocks: Don't return early on a malformed block.json
* Fixes #41121
chad1008 pushed a commit that referenced this pull request May 19, 2022
@dd32 @chad1008
Blocks: Don't abort registering blocks when a missing block file is f…
a7b42e0 
…ound. (#41122)

* Don't abort registering blocks when a missing block file is found.
* Blocks: Don't return early on a malformed block.json
* Fixes #41121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@gziolo gziolo Awaiting requested review from gziolo

Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Milestone
Gutenberg 13.2
4 participants
@dd32 @Mamaduka @gziolo @chad1008