Migrate template part test to playwright #41048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
talldan
commented
May 13, 2022
| @@ -59,6 +59,6 @@ export class Editor { | |||
| openDocumentSettingsSidebar = openDocumentSettingsSidebar; | |||
| openPreviewPage = openPreviewPage; | |||
| saveSiteEditorEntities = saveSiteEditorEntities; | |||
| selectBlockByClientId = selectBlockByClientId; | |||
| selectBlocks = selectBlocks; | |||
There was a problem hiding this comment.
I think I accidentally introduced selectBlockByClientId in #40815.
I've changed it here so it can multiselect, and the way it used clientIds wasn't very useful, so now uses locators.
|
Size Change: -423 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
May 24, 2022
kevin940726
approved these changes
May 25, 2022
| { has: paragraphBlock2 } | ||
| ); | ||
|
|
||
| // TODO: I couldn't find an easy way to assert that the same template |
There was a problem hiding this comment.
I think this is good enough. We probably can do better but I don't think that matters that much 😛.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851
Migrates the template part tests to playwright.
How?
The original tests have been rewritten substantially, so it may be hard to compare old to new.
I felt the original tests tried to do too much, and that's probably why they're one of the more flakier set of tests, so I've tried to simplify things as much as possible.