-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pocket Casts embed block variation #41006
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @phcp! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
* Add embed block variation for Pocket Casts * Add the Pocket Casts icon on embed icons file
691de46
to
181ab97
Compare
* Update the block description * Add audio keywork to the block * Change the Pocket Casts icon to use the brand color
The WP trac ticket was originally closed due to auto-discovery working. I've reopened it pending the inclusion of a block (WP#55860 (comment)). Once this PR is merged I will add the trac ticket to the next milestone. |
Congratulations on your first merged pull request, @phcp! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
@phcp While collecting props and credits for 6.1, it seems you are one of a few dozen folks that have not connected their WordPress.org account to their GitHub profile. Could you share your WordPress.org account so that we can ensure you're properly credited on the About page for WordPress 6.1? Connecting your accounts will also help those collecting this in the future. Thanks in advance! |
@desrosj My WordPress.org account is |
""need to subscribe to a premium Pocket Casts account to add your favorite or own Pocket Casts content into the block" Am I reading this correctly? |
What?
Introduces the embed block variation for Pocket Casts (WP55860).
Why?
To enable embedding Pocket Casts on WordPress posts using blocks.
How?
Adding the variation attributes for the Pocket Casts in the embed block variations array, also adding the Pocket Casts icon on the embed icons file.
Testing Instructions
By adding the Pocket Casts block
3.1. Examples:
https://pca.st/k2rof194
,https://pca.st/qekyjgs6
,https://pca.st/63wN
By pasting a Pocket Casts URL
2.1. Examples:
https://pca.st/k2rof194
,https://pca.st/qekyjgs6
,https://pca.st/63wN
Screenshots