Fix vertical alignment of rows in nav panel #40883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Navigation in Site View
|
Size Change: -4 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
javierarce
reviewed
May 16, 2022
There was a problem hiding this comment.
Nice! I'd say we can merge it, but I have one suggestion: removing the align-items property works well because block-editor-list-view-block-contents defines it as align-items: center… wouldn't it make sense to set it here too in case someone changes it there?
|
Good question. I'm not 100% sure if both features (List View and the Navigation Panel) are using the same underlying component. Ideally we shouldn't be declaring this style twice else we'll run into more issues like the one I'm trying to solve here :D Perhaps @ciampo has some insight on how best to proceed? |
ciampo
approved these changes
May 19, 2022
There was a problem hiding this comment.
Hey 👋 Sorry for the late answer (I was AFK in the past days).
The styles that @javierarce refers to come indeed from the ListView component, defined in the @wordpress/block-editor package. I am not an expert of the ListView component necessarily, as it's not part of the @wordpress/components package.
The ListView component already takes care of displaying items correctly, and my general option is that we should try to override styles as least as possible — from my point of view, I believe that it's safe to remove the align-items style overrides as @jameskoster initially proposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the vertical alignment of elements inside rows in the Navigation Menus panel to be centrally aligned:
Why?
Because the current alignment is inconsistent with other implementations. Compare List View with the Navigation Menus panel:
Notice that the text label is mis-aligned.
How?
Updates
align-itemson.edit-site-navigation-inspector .block-editor-list-view-leaf .block-editor-list-view-block-contents.Testing Instructions