-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical alignment of rows in nav panel #40883
Conversation
Size Change: -4 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'd say we can merge it, but I have one suggestion: removing the align-items
property works well because block-editor-list-view-block-contents
defines it as align-items: center
… wouldn't it make sense to set it here too in case someone changes it there?
Good question. I'm not 100% sure if both features (List View and the Navigation Panel) are using the same underlying component. Ideally we shouldn't be declaring this style twice else we'll run into more issues like the one I'm trying to solve here :D Perhaps @ciampo has some insight on how best to proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 Sorry for the late answer (I was AFK in the past days).
The styles that @javierarce refers to come indeed from the ListView
component, defined in the @wordpress/block-editor
package. I am not an expert of the ListView
component necessarily, as it's not part of the @wordpress/components
package.
The ListView
component already takes care of displaying items correctly, and my general option is that we should try to override styles as least as possible — from my point of view, I believe that it's safe to remove the align-items
style overrides as @jameskoster initially proposed.
What?
Updates the vertical alignment of elements inside rows in the Navigation Menus panel to be centrally aligned:
Why?
Because the current alignment is inconsistent with other implementations. Compare List View with the Navigation Menus panel:
Notice that the text label is mis-aligned.
How?
Updates
align-items
on.edit-site-navigation-inspector .block-editor-list-view-leaf .block-editor-list-view-block-contents
.Testing Instructions