Set 0o777 permissions on downloaded sources #40864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
gziolo
added
[Type] Bug
|
cc @westonruter, could you give this one a test? I still can't replicate the permissions issue, even when using a zip download for WordPress 🤔 |
westonruter
reviewed
May 17, 2022
| @@ -85,6 +86,8 @@ async function downloadSource( source, options ) { | |||
| } else if ( source.type === 'zip' ) { | |||
| await downloadZipSource( source, options ); | |||
| } | |||
|
|
|||
| await fs.promises.chmod( source.path, 0o777 ); | |||
There was a problem hiding this comment.
This seems it would only be applying to the path and it wouldn't be recursively applying the to all files in the directory tree, right?
There was a problem hiding this comment.
The chmodr package should be used instead, perhaps. However, I can't vouch for it.
Might be better to use the approach in #22515 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sets permissions on downloaded sources after downloading them
Why?
There is a problem in wp-env where sources (especially downloaded ones, apparently) can have insufficient permissions, which means Wordpress may not start whatsoever.
How?
Set 777 (rwx) permissions for all users for all downloaded sources.
Testing Instructions
packages/env/bin/wp-env start --updateand see if it solves the problemScreenshots or screencast
n/a