-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Tools: Update actions/setup-node GitHub action #40816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
gziolo
added
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
labels
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Build Tooling
Issues or PRs related to build tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for changes in WordPress core applied by @desrosj with WordPress/wordpress-develop@567b837.
This PR updates
actions/setup-node
GitHub action from2.4.1
to3.1.0
.Additionally, this updates nearly all instances of the
actions/setup-node
action to replace thenode-version
option with the newnode-version-file
. This simplifies the process of changing the version of NodeJS used in workflows by only requiring the version to be changed once in the.nvmrc
file. We only exclude places where wematrix
is used more than one version of Node.js or to use it also for caching.Why?
To have the most recent version and to align with WordPress core.
How?
An update for workflows that use
actions/setup-node
action.Testing Instructions
All CI jobs should still pass and use Node.js 14.