Fix/block meta icon prop errors #40710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @danieliser! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
Mamaduka
added
[Type] Bug
Mamaduka
approved these changes
Apr 29, 2022
|
@Mamaduka - Thanks for the quick merge 👍 . |
Mamaduka
added
the
Backport to WP Minor Release
|
Adding backport to minor release label. |
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
* Fix hyphenated prop errors * Correct wrong icon export name
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 8b69086 |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
[x] Fix console errors due to usage of hyphenated props on JSX elements.
[x] Update icon export name appropriately.
Why?
There were errors being thrown in the console when using the
blockMetasvg icon.Warning: Invalid DOM property `fill-rule`. Did you mean `fillRule`?Warning: Invalid DOM property `clip-rule`. Did you mean `clipRule`?Testing Instructions
blockMetasvg icon and check the console.Screenshots or screencast