Try: Simpler clear button. #40437
Merged
Try: Simpler clear button. #40437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.24 kB (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Thank you for the review! Because I'm not quite sure how widely and in all the context the button may be used, I'll let this one gather a few more reviews before I press the button. |
|
Was there reasoning to remove the border by default? |
|
Sure, it's larger font size but with the same visual footprint. And it's a small step towards this type of clear button: |
|
Any objections to landing this one? |
|
I think I'll land this one, mostly because it makes the larger and more legitble, it looks good inside duotone, gradient and inline formatting menus, and it gets us one minucscule step closer towards the clear button inside the Border control. It's also a tiny PR, and if we have to revert it for whatever reason, that should be easy. |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The clear button looks a litte out of place, being small text in context of larger text:
This PR changes the default appearance to be larger but have the same general footprint:
Testing Instructions
This likely needs decent testing. The only instance of this specific clear button I was able to find, was inside the Image block duotone filter dropdown. But it's very probably used in more places.