Migrate style variation test to Playwright #40216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinyAhin
added
the
[Type] Automated Testing
|
Size Change: +1.77 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Apr 11, 2022
Co-authored-by: Kai Hao <[email protected]>
oandregal
reviewed
Apr 20, 2022
| await pageUtils.createNewPost(); | ||
|
|
||
| // Inserting a quote block | ||
| await pageUtils.insertBlock( { |
There was a problem hiding this comment.
Hey, as far as I understand, this PR changed the original test behaviour. Previously, we:
- added a block
- typed some content
These steps covered the case for which we wanted to make sure that users could type right after the block was inserted.
The playwright test does this instead:
- adds a block with the contents we want
It doesn't look like we're testing for typing. Sorry, I'm not very familiar with playwright, but shouldn't we respect the existing behavior when migrating tests? @JustinyAhin @kevin940726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrate
style-variation.test.jsto its Playwright version.Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright -- /test/e2e/specs/editor/various/style-variation.spec.js.