Update the Post Tags block icon #40096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice win, but there's also this one, should we use that instead?
|
|
Size Change: +9 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Oh cool, I didn't know about that one, I'll update the PR. I assume there isn't one for Post Date? Something to discuss separately, but I'm not entirely sure we need the dedicated icons for these blocks. |
|
|
|
Yeah I've been back and forth on that, I've even hoped to find a template for these smaller repeated blocks so they don't all have to look completely unique. But given the importance of list view, I think there's value in differentiating between blocks. In the case of tag cloud and post tags it's not likely they'll be used together — but in other cases it's more common. |
jasmussen
approved these changes
Apr 6, 2022
priethor
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post Tags is currently using the same icon as Post Categories.
Before:
After:
