Try/nav dedicated sidebar 2 #39885
Closed
Try/nav dedicated sidebar 2 #39885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.54 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
scruffian
commented
Mar 30, 2022
|
|
||
| @include break-small() { | ||
| padding-left: $grid-unit-30; | ||
| padding-left: $grid-unit-20; |
There was a problem hiding this comment.
presumably since this matches the value above we don't need it.
getdave
reviewed
Mar 31, 2022
| @@ -176,6 +176,14 @@ export const rootEntitiesConfig = [ | |||
| baseURLParams: { context: 'edit' }, | |||
| key: 'plugin', | |||
| }, | |||
| { | |||
| label: __( 'Navigation' ), | |||
There was a problem hiding this comment.
We should drop this change. It's not a good idea.
scruffian
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧🚧🚧 Still very much a WIP. 🚧🚧🚧
What?
This is another attempt at #38600, but this time moving the pinned items to the header.
Why?
Part of #36667.
How?
This requires changing the Interface Skeleton component which is quite a risky change. We should try to find a way to do this in smaller increments but that has proven difficult so far.
Testing Instructions
Open the site editor and play with templates/template parts/global styles and navigation sidebar.
Screenshots or screencast
sidebare3.mp4