Use block specific filters for the backward compatibility markup hooks #39321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
ocean90
approved these changes
Mar 10, 2022
youknowriad
deleted the
update/improve-backward-compatibility-image-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a code quality improvement to this PR #38657
The linked PR removed some useless "div" containers from image blocks that use left/right/center alignment. It did so only for themes that support the layout feature but to retain backward compatibility the divs are added back in the frontend using the render_block callback.
But since, WP 5.7 there are specific block filters we can use instead of the generic one.
Why?
This is a code quality and a tiny perf improvement.
Testing Instructions