Site Editor: Add template check to 'setPage' action. #38656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Edit Site
|
Size Change: +8 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
talldan
reviewed
Feb 14, 2022
| coreStore, | ||
| '__experimentalGetTemplateForLink', | ||
| page.path | ||
| ); | ||
|
|
||
| if ( ! template ) { | ||
| return; |
There was a problem hiding this comment.
Should there be any kind of visible error for users if there's no template?
If so, perhaps a notice can be dispatched.
There was a problem hiding this comment.
The editor will display a notice if the template doesn't exist:
gutenberg/packages/edit-site/src/components/editor/index.js
Lines 253 to 267 in 9543b72
There was a problem hiding this comment.
Great, in that case I've approved the PR.
|
Thanks for the review, @talldan. |
Mamaduka
added
the
Backport to WP Minor Release
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
added a commit
that referenced
this pull request
Feb 16, 2022
|
I was just going to create an issue for this as I had an odd behaviour while adding template parts to a classic theme. I basically only had a @Mamaduka It seems that I'll get the "You attempted to edit an item that doesn't exist. Perhaps it was deleted?" message now? Do you think I should create another issue since I'm kind of expecting that it loads the Some quick steps to reproduce:
|
|
Hi, @ocean90 A separate issue would be great 🙇 I think fixing this error just surfaced other problems with template resolution. |
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
__experimentalGetTemplateForLinkselector can returnnullwhen there's no template. PR adds check to avoid errors during destructuring.gutenberg/packages/core-data/src/selectors.js
Lines 880 to 895 in fe8707b
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).