Site Editor: Fix alignment styles #38597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Site Editor
|
Size Change: +23 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
|
hi @scruffian This PR made me think of these data-aligned wrappers again and I opened this alternative PR #38613 It's a bit more ambitious but if we manage to land, it will simplify theme styling a lot. |
|
Closing in favour of #38613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When alignment styles are output in the Site Editor, they use classes (alignwide, alignfull, alignleft, alignright), not data attributes ("data-align"="wide", "data-align"="full", "data-align"="left", "data-align"="right"). This PR sets those classes in the JS alignment styles so that the alignment styles in the Site Editor work for post content.
Testing Instructions
Using the Livro theme, add this content to a post:
Open the home template in the Site Editor and check that the alignment styles are working as in the screenshot.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).