Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Fix issue where block collapses to zero height when empty. #38439

Closed
wants to merge 3 commits into from
Closed

Navigation: Fix issue where block collapses to zero height when empty. #38439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
821161f
Navigation: Fix issue where block collapses to zero height when empty.
jasmussen Feb 2, 2022
7678be6
Fix typo.
jasmussen Feb 3, 2022
1dac9ad
Clarify comment.
jasmussen Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/block-library/src/navigation/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,18 @@ $color-control-label-height: 20px;
}
}

// Selected "Start empty" state.
// In this state, the block is entirely empty and will collapse to zero height unless there's
// content inside. The below rule lets the placeholder stay in an invisible state to avoid
// collapsing and shifting the layout.
// @todo: Other container blocks show a white/bordered add block button when empty.
// If we implement the same for Navigation, that button would also prevent the collapse
// so this fix could be removed.
.wp-block-navigation.is-selected .wp-block-navigation__container .wp-block-navigation-placeholder__preview:first-of-type {
visibility: hidden;
display: flex;
}

// Selected state.
.wp-block-navigation-placeholder__preview,
.wp-block-navigation-placeholder__controls {
Expand Down