Remove the aria-label from the site title block #38432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An aria-label is added to the site title when the "Make title link to home" and the "open in new tab" options are enabled.
The purpose is to announce to screen readers that the link opens in a new tab.
The problem is that only the message "opens in a new tab" is announced to screen readers, because the aria-label replaces the link text.
There are many past discussions about the underlying problem, but I was not aware of them when I added the aria-label to the block. It is clear from these past discussions that the aria-label, even if it would include the site title in the label, is not the correct solution.
This pr removes the aria-label and restores the link text.
Testing Instructions
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).