Improve File Block text handling and flexibility #38198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #10967
I replaced the
RichText
component with aPlainText
component as seemed to be decided in the referenced issue. However, I'm not sure this is the best fix. To make it look cleaner, I did remove the border and box shadow on the textarea element, buttextarea
naturally wants to have some space around it, which means it's not as accurate a representation of the front-end.How has this been tested?
I tried out the File block, saved it, changed it, and tried pasting linked text in it (as reported in the issue). All seems to work just fine.
Screenshots
With Plain Text in the Editor:
Front end output:
Types of changes
Bug fix: Changes one of the editable elements so copy/pasting formatting doesn't come through.
Question
Does removing the border/box shadow around the input make this element less accessible?
Checklist:
*.native.js
files for terms that need renaming or removal).