Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve File Block text handling and flexibility #38198

Closed
wants to merge 5 commits into from

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Jan 25, 2022

Description

Fix for #10967

I replaced the RichText component with a PlainText component as seemed to be decided in the referenced issue. However, I'm not sure this is the best fix. To make it look cleaner, I did remove the border and box shadow on the textarea element, but textarea naturally wants to have some space around it, which means it's not as accurate a representation of the front-end.

How has this been tested?

I tried out the File block, saved it, changed it, and tried pasting linked text in it (as reported in the issue). All seems to work just fine.

Screenshots

With Plain Text in the Editor:
Screen Shot 2022-01-24 at 9 38 40 PM

Front end output:
Screen Shot 2022-01-24 at 9 39 07 PM

Types of changes

Bug fix: Changes one of the editable elements so copy/pasting formatting doesn't come through.

Question

Does removing the border/box shadow around the input make this element less accessible?

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@aurooba aurooba changed the title File Block: file name needs to use PlainText component Improve File Block text handling and flexibility Jan 25, 2022
@mtias
Copy link
Member

mtias commented Mar 28, 2022

Also related #39118

@mtias mtias added the [Block] File Affects the File Block label Mar 28, 2022
@paaljoachim
Copy link
Contributor

Hey @aurooba it would be great with a status update on this PR.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants