[RNMobile] Fix text formatting mode lost after backspace is used #37676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
fluiddot
commented
Dec 31, 2021
Comment on lines
8
to
11
| # Changes Aztec reference to last commit from https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1346 PR. | ||
| # ONLY FOR TESTING, IT SHOULD BE DELETED ONCE THE AZTEC PR IS MERGED! | ||
| pod 'WordPress-Aztec-iOS', :git => 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', :commit => 'd68c76ec8f01490c741077dccefc17b17ce19f2d' | ||
|
|
There was a problem hiding this comment.
I updated the Aztec-iOS reference so it points to the PR (wordpress-mobile/AztecEditor-iOS#134) where the shouldRecalculateTypingAttributesOnDeleteBackward variable was added. Once that PR is merged, we should remove the changes made to Podfile and Podfile.lock files.
fluiddot
changed the title
2 tasks
antonis
reviewed
Jan 4, 2022
There was a problem hiding this comment.
Great work @fluiddot 👍
I tested the Android implementation with a local build and it worked as expected 🎉
The code changes on the iOS side both on this PR and on Aztec LGTM but I haven't tested yet. I will have a look tomorrow if @guarani does not beat me to this 😄
guarani
approved these changes
Jan 4, 2022
# Conflicts: # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile # packages/react-native-editor/ios/Podfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34938.
Related to:
Description
This PR fixes the issue #34938 by introducing a couple of changes in Aztec-Android and Aztec-iOS. The main purpose of the change is to prevent Aztec modifying internally the active text format when the text changes and letting the RichText component have full control over it.
NOTE: Further information about the issue and this approach can be found in this comment #34938 (comment).
How has this been tested?
iOS:
Android:
Screenshots
iOS
Kapture.2021-12-31.at.13.34.42.mp4
ios-format-backspace-fix.mp4
Android
android-format-backspace-issue.mp4
Screen_Recording_20211231-165915_Gutenberg.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).