Custom keys from theme.json: fix kebabCase conversion
#37380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Bug
oandregal
requested review from
a team and
gziolo
and removed request for
a team
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Dec 14, 2021
gziolo
reviewed
Dec 14, 2021
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36875
The conversion of the
customCSS variables in the front-end wasn't following the same rules as in the site editor. Additionally, it was also following different rules from the preset CSS variables.How to test
Add something like this to a theme with theme.json (eg: empty theme):
{ "version": 1, "settings": { "color": { "palette": [ { "slug": "white2black", "color": "value", "name": "White to Black" } ] }, "custom": { "white2black": "value" } } }Visit the front-end, post, and site editor and verify that the values are serialized like this in all cases:
Note how
white2blackis converted intowhite-2-black.