Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gutenberg_ prefix from @wordpress/block-library #37341

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

noisysocks
Copy link
Member

Description

Removes two instances of the gutenberg_ prefix appearing in @wordpress/block-library.

This code is copied to Core as-is so it shouldn't reference Gutenberg.

We really ought to add a lint rule for this... one day!

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@noisysocks noisysocks added [Type] Code Quality Issues or PRs that relate to code quality [Package] Block library /packages/block-library labels Dec 13, 2021
@noisysocks noisysocks added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 13, 2021
@noisysocks noisysocks merged commit c94887f into trunk Dec 14, 2021
@noisysocks noisysocks deleted the remove/gutenberg-prefix-from-block-library branch December 14, 2021 00:48
noisysocks added a commit that referenced this pull request Dec 14, 2021
* Remove gutenberg_ prefix from block library

* Use the full name of the block
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 14, 2021
@tellthemachines tellthemachines removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants