-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: add customized indicator to plugin templates that have been customized #37329
Conversation
Size Change: -2 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
I tried, but I couldn't get the WooCommerce templates to be listed at all. I probably missed something when I tried to setup / build WooCommerce blocks. |
3f940dc
to
212ff67
Compare
Thanks for taking a look, @carolinan! I updated the PR description with alternative testing steps that don't require WooCommerce (but instead, require adding some custom code), hope that's easier to test. Also, let me know if you want me to help set up WC if you still want to test the real-life testing steps. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the PR with the new instructions. Works as described, thank you.
Cherry-picked for the minor. |
Description
When a template or template part has been customized, Gutenberg displays a blue circle on top of the icon to make it clear it's a custom template. However, that style is not currently applied to templates whose origin is a plugin. This PR fixes that.
How has this been tested?
With Twenty Twenty Two and example code
With WooCommerce
You will need to install WooCommerce 6.0 or later and clone WC Blocks repo (and then run
composer i && npm i && npm run build
). Once that's done, these are the testing steps:Types of changes
Bugfix
Checklist:
*.native.js
files for terms that need renaming or removal).