Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a UI warning when user does not have permission to update/edit an existing Navigation block #37286

Merged
merged 17 commits into from
Dec 16, 2021
Merged

Show a UI warning when user does not have permission to update/edit an existing Navigation block #37286

merged 17 commits into from
Dec 16, 2021

Commits on Dec 14, 2021

  1. Show warning when user has insufficient permision to edit the given Nav

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    6cadccc View commit details
    Browse the repository at this point in the history

  2. Move warning underneath block but allow viewing

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    5b52dd5 View commit details
    Browse the repository at this point in the history

  3. Sync warning display with entity loading

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    15383c1 View commit details
    Browse the repository at this point in the history

  4. Include ref as effect dependency

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1fef7c9 View commit details
    Browse the repository at this point in the history

  5. Revert unintentional edit to comment placement

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7f8b0ce View commit details
    Browse the repository at this point in the history

  6. Show permisisons warning using global notices system

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b0370a2 View commit details
    Browse the repository at this point in the history

  7. Hide delete and rename inspector items based on perms

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    6b3ceac View commit details
    Browse the repository at this point in the history

  8. Switch to snackbar notice

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    b9cf2f7 View commit details
    Browse the repository at this point in the history

  9. Add e2e test covering update permission notice

    @getdave
    getdave committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    115deeb View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Try removing forward slash to see if test passes

    @talldan
    talldan committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    88c2aba View commit details
    Browse the repository at this point in the history

  2. Remove usage of uniqueId 

    Resolves #37286 (comment)
    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    d9798ad View commit details
    Browse the repository at this point in the history

  3. Update error message to use clearer terminology 

    Addressses #37286 (comment)
    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    6461748 View commit details
    Browse the repository at this point in the history

  4. Fix test to match code error message string change

    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    2263f09 View commit details
    Browse the repository at this point in the history

  5. Move permissions selectors to existing hook

    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    339dcba View commit details
    Browse the repository at this point in the history

  6. Add explaination of requirement for 403 expect for Nav Areas

    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    cfc7301 View commit details
    Browse the repository at this point in the history

  7. Attempt to fix flaky test on CI

    @getdave
    getdave committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    06704cd View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Remove ref as a dependency to useSelect

    @talldan
    talldan authored Dec 16, 2021
    Configuration menu
    Copy the full SHA
    ea1fb57 View commit details
    Browse the repository at this point in the history