Fix theme requirement validation with WP 5.8 #37226
Conversation
Mamaduka
added
[Feature] Themes
| * | ||
| * @return boolean Whether the current theme is a block theme or not. | ||
| */ | ||
| function gutenberg_is_fse_theme() { |
There was a problem hiding this comment.
We should move this in compat/wordpress-5.9/theme.php.
Mamaduka
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Merging this should also fix failing performance checks. |
lib/compat/wordpress-5.9/theme.php
Outdated
|
|
||
| /** | ||
| * Note: We have to maintain this function for backward compatibility with WP 5.8. | ||
| * Only remove once 5.9 is the minimum supported WordPress version for the Gutenberg plugin. |
There was a problem hiding this comment.
We could remove this line for 5.9, as it's already suggested by structure we are trying to follow for compat changes per wp version.
I think your PR description (with a small rewording/changes) might be a better fit as a comment:
The validate_theme_requirements method is using gutenberg_is_fse_theme in older versions of WP.
|
Thanks, Nik. I've updated the commend and will merge this once all checks are green. |
|
@noisysocks, we might want to backport this to the core branch since original PR is also marked for backporting. |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
So we backport this to wp/trunk but not core |
|
@youknowriad, right, backport only to |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
* Fix theme requirement validation with WP 5.8 * Use compat file * Update comment
Description
Fixes regression when it wasn't possible to activate block theme with WP 5.8. The
validate_theme_requirementsmethod is usinggutenberg_is_fse_themein older versions of WP.Introduced in #37218.
How has this been tested?
Try activating block theme with WP 5.8
Screenshots
Types of changes
Bugfix/Regression
Checklist:
*.native.jsfiles for terms that need renaming or removal).