Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove versioning in theme schema descriptions #37165

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Remove versioning in theme schema descriptions #37165

merged 1 commit into from
Dec 7, 2021

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Dec 6, 2021

Description

This removes mentions of versions in the descriptions of properties in the theme.json schema as mentioned in #36917 (comment)

How has this been tested?

Check that all instances of "Since 5.8" or "Gutenberg plugin required" were removed.

Screenshots

N/A

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@ajlende ajlende added the [Type] Developer Documentation Documentation for developers label Dec 6, 2021
@ajlende ajlende self-assigned this Dec 6, 2021
mkaz
mkaz approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
We may want to backport the first version to wp/5.8 branch so it represents a "version=1" schema

@ajlende
Copy link
Contributor Author

ajlende commented Dec 7, 2021

We may want to backport the first version to wp/5.8 branch so it represents a "version=1" schema

Sounds like a great idea! I know folks are looking for that—someone mentioned v1 in the [announcement post])https://make.wordpress.org/themes/2021/11/30/theme-json-schema/#comment-44322).

@ajlende ajlende changed the title Remove versioning in schema descriptions Remove versioning in theme schema descriptions Dec 7, 2021
@ajlende ajlende merged commit f0e291b into trunk Dec 7, 2021
@ajlende ajlende deleted the fix/theme-json-schema-remove-since-descriptions branch December 7, 2021 14:18
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 7, 2021
@ajlende ajlende added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Jan 28, 2022
@ajlende ajlende mentioned this pull request Jan 28, 2022
Closed
8 tasks
@Mamaduka
Copy link
Member

Cherry-picked for 5.9.1

@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Feb 16, 2022
Mamaduka pushed a commit that referenced this pull request Feb 16, 2022
@ajlende @Mamaduka
Remove versioning in theme schema descriptions (#37165)
621c3c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@colorful-tones colorful-tones Awaiting requested review from colorful-tones

@oandregal oandregal Awaiting requested review from oandregal

Assignees

@ajlende ajlende

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlende @Mamaduka @mkaz