Update: Make the color popover on the gradient picker appear as expected #37115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
|
Size Change: +179 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/make-color-popover-appear-on-the-side-of-the-gradient-picker
branch
2 times, most recently
from
4aba69a to
7bf7b06
Compare
jorgefilipecosta
force-pushed
the
update/make-color-popover-appear-on-the-side-of-the-gradient-picker
branch
from
7bf7b06 to
327725e
Compare
jorgefilipecosta
deleted the
update/make-color-popover-appear-on-the-side-of-the-gradient-picker
branch
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
ciampo
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Hey @jorgefilipecosta , when you're carrying out work in the @wordpress/components package, it would be better to add an entry to the CHANGELOG, especially when introducing API changes (like the __experimentalIsRenderedInSidebar prop on GradientPicker and CustomGradientPicker)
I also noticed that this PR was merged without any review — feel free to add @mirka and/or myself to the list of the reviewers for anything components-related.
|
Hi @ciampo,
Changelog entry proposed at #37457.
Thank you for the availability in the future I will include you both as reviewers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes color popover on the custom gradient picker it makes the popover appear the same as the one that appears on the color palette custom color picker.
It fixes the shadow border, and the popover position to be on the side.
How has this been tested?
I verified the color picker on the custom gradient component appears as expected.
Screenshots