Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ImportForm as function component and use hooks #36938

Conversation

amustaque97
Copy link
Member

@amustaque97 amustaque97 commented Nov 28, 2021

This PR is a part of issue #22890

Description

Refactor ImportForm as function componenet. All componenet test case are passing.
After changes, it is working as expected.

How has this been tested?

  1. Open link http://localhost:8888/wp-admin/edit.php?post_type=wp_block
  2. Create a new file with name hello-world.json and paste the below code
{
  "__file": "wp_block",
  "title": "HelloWorld",
  "content": "<!-- wp:heading -->\n<h2 id=\"hello-world-importform\">Hello, World - ImportForm</h2>\n<!-- /wp:heading -->"
}
  1. On the reusable blocks page, import the saved file hello-world.json
  2. Verify the success message.
  3. Upload non-json file and verify an error message.

Screenshots

  • In case of invalid file

image

  • In case of a successful import

image

Types of changes

Code Quality

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Refactor ImportForm as function componenet. All componenet test case are passing.
After changes, it is working as expected.
Introduced `formRef` ref since it will be reliable and safe if in future
we decide to memoize it.
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the contribution.

@youknowriad youknowriad merged commit 89188ba into WordPress:trunk Dec 2, 2021
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 2, 2021
@amustaque97 amustaque97 deleted the refactor/ImportForm-use-hooks-and-function-component branch December 2, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants