Add plugin meta data to Nav Area block deprecation notice #36777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses feedback in #36727 (comment)
getdave
added
[Feature] Block Validation/Deprecation
youknowriad
reviewed
Nov 23, 2021
| @@ -54,6 +54,7 @@ function NavigationAreaBlock( { attributes, setAttributes } ) { | |||
|
|
|||
| deprecated( 'wp.blockLibrary.NavigationArea', { | |||
| since: '5.9', | |||
There was a problem hiding this comment.
I think the number here should be 12.0 or something like (plugin version)
|
Size Change: +11 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
adamziel
reviewed
Nov 23, 2021
adamziel
approved these changes
Nov 23, 2021
youknowriad
approved these changes
Nov 23, 2021
|
Waiting on those tests. Guess I can force merge if necessary. |
getdave
deleted the
update/improve-deprecation-notice-for-nav-areas-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback in #36727 (comment)
Description
Addresses feedback from @youknowriad in #36727 (comment) to mark the deprecation notice with
pluginmetadata to denote that this has never landed in a stable release of Core.How has this been tested?
Check I typed things correctly and there are no errors in the console.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).