Data: clean up registerGenericStore param names #36300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
dmsnell
reviewed
Nov 8, 2021
| unsubscribeFromRootStore(); | ||
| } | ||
| unsubscribeFromStoreEmitter(); | ||
| unsubscribeFromStore?.(); |
There was a problem hiding this comment.
do we have this in our Babel transforms? I didn't realize we could use optional-chaining in the JavaScript code
There was a problem hiding this comment.
The support was added via #19831.
There was a problem hiding this comment.
There's also plenty of other places in the codebase where ?. is already used.
dmsnell
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Thanks for taking this one. Renaming key was one of the things I planned on doing after some other updates anyway, so I appreciate that I won't have to do that now.
We have other uses of key, such as in instantiateReduxStore, but I think it's fine to tackle those in separate work. That function also calls it a "unique namespace identifier," and I had wondered if we might review the use of name vs namespace.
All things here look like positive changes 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36190 -- improves param names of the
registerGenericStoremethod. The second parameter is not aconfig, but a store instance, so I call itstore. Naming the first parameter asnameinstead ofkeyis also more consistent with the rest of the codebase.How to test:
Shouldn't change any behavior, it's just renaming params and variables.