Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhook _block_template_render_title_tag #36133

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Unhook _block_template_render_title_tag #36133

merged 1 commit into from
Nov 2, 2021

Conversation

aristath
Copy link
Member

@aristath aristath commented Nov 2, 2021

Description

Fixes #34106

When gutenberg_render_title_tag was backported to WP as _block_template_render_title_tag, we should have unhooked it along with _wp_render_title_tag.
That was not done, and as a result we have 2 <title> elements in the head.
Additional information is available in the ticket.

This PR simply unhooks _block_template_render_title_tag to fix the issue.

How has this been tested?

Tested with a block theme, creating a template override for a single page.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@aristath aristath requested review from gziolo and carolinan November 2, 2021 07:49
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍🏻

@carolinan carolinan merged commit bf13d39 into trunk Nov 2, 2021
@carolinan carolinan deleted the fix/34106 branch November 2, 2021 08:33
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Nov 2, 2021
aristath added a commit to Yoast/wordpress-seo that referenced this pull request Nov 2, 2021
@andrewserong andrewserong added the [Type] Bug An existing feature does not function as intended label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated <title> tag
4 participants