Post Template Block: Move inner blocks container to separate component #35945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
Closed
10 tasks
|
Size Change: +31 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Oct 26, 2021
|
I didn't get too deep into debugging, but I'm also not totally sure why this change was needed. I did verify that I can see the issue on trunk, and that it is resolved on this branch for me as well 👍 |
gziolo
reviewed
Nov 2, 2021
| @@ -149,7 +154,7 @@ export default function PostTemplateEdit( { | |||
| > | |||
| { blockContext === | |||
| ( activeBlockContext || blockContexts[ 0 ] ) ? ( | |||
| <li { ...innerBlocksProps } /> | |||
| <PostTemplateInnerBlocks /> | |||
There was a problem hiding this comment.
I think it makes a lot of sense because in practice this creates a list of Post Template inner blocks so all block props should be computed in that context that is set by the BlockContextProvider.
@michalczaplinski, we will need to apply the same changes as in the final version of this PR to the Comment Template block.
There was a problem hiding this comment.
Opened #36174 to align the Comment Template block.
There was a problem hiding this comment.
Whoop, sorry for getting to this late @gziolo and thanks for taking care of this! 😊
andrewserong
force-pushed
the
update/post-template-block-move-inner-blocks-to-separate-component
branch
from
3af2d19 to
5678a1d
Compare
Thanks for confirming, @gziolo! I've given this a rebase to keep it current and re-tested and it still appears to be working well, so I'll merge this in now. Happy to do any follow-ups if there are any issues. |
andrewserong
deleted the
update/post-template-block-move-inner-blocks-to-separate-component
branch
gziolo
added a commit
that referenced
this pull request
Nov 3, 2021
7 tasks
gziolo
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the inner blocks container for the Post Template block to a separate component, to ensure that the result of
useInnerBlocksPropsis always applied to same React node relative to the call to the hook.I'm not 100% sure why this fixes it, but it resolves the following issue:
Before: in a long Post Template block within a long query loop (e.g. within the Index template of the TT1-Blocks theme with 2+ published posts) if you click on a block within the first post within the loop, then scroll down to click on a similar block within another post within the loop, then the scroll position of the editor moves when the parent Post Template block is selected.
After: on click, the selection changes, but the scroll position does not move away unexpectedly.
How has this been tested?
Note: there is a separate issue that on the first click, the Post Template block is selected instead of the target block. That's logged in issue #35944 and is to do with the way the Post Template block only renders one post at a time as live editable blocks (the other posts are rendered as BlockPreviews). This PR only seeks to address the scrolling issue
Screenshots
Note: in the before screenshot, after clicking the similar block in the next post, the viewport is scrolled to the bottom of the page unexpectedly. In the After screenshot, the viewport is not scrolled unexpectedly (but it still takes a couple of clicks to activate the desired block as noted in #35944)
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).