Templates: Only include templates for the current post types #35802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
Mamaduka
commented
Oct 20, 2021
lib/full-site-editing/class-gutenberg-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
|
Size Change: +8 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
The other related thing that would be good is to exclude the hierarchy templates from the dropdown (things like index, single, archive..., we should only load the custom templates that don't have any "hierarchy" meaning like we do in classic themes) |
Mamaduka
force-pushed
the
fix/custom-templates-post-types
branch
from
174829c to
be7686b
Compare
|
@youknowriad added exclusion logic in be7686b. |
@jasmussen, that's correct. @youknowriad updated logic as you suggested. |
|
I haven't tested this in action yet, but the code looks good 👍 |
|
@youknowriad, re-filtering: I think parts of Question: When do we usually start moving PHP parts into WP Core PRs/patches from the plugin? |
I'm worried about splitting filtering logic into two places, so I'd prefer if we move the filtering there (even without refactoring) if possible.
It seems we're 20 days before "alpha", I think that's a good time to start thinking about these things. Ideally we should have an editor lead defined though to coordinate with them and make decisions about what to include... I'm not sure when we'll get that information. |
|
I agree with hiding index, archive, 404, but not single post type templates. Only because having them there makes it easier for users to edit the default for post/page when they are editing that content. |
The "default template" is already added automatically in the frontend, so I think this covers your point here. |
|
I mean I agree that if there is a custom template assigned to page in theme.json, it should only show for page. |
Isn't default the "default" that you use when you create a new template? that the theme can define? |
No, it's the template inherited from the template hierarchy, so |
|
Can we change that label to what it actually is? (in a different PR) So if I am editing a page it says page automatically, not "default". |
|
I think that should be doable, right now the right label is actually rendered on the header of the panel
I don't remember exactly where the "Default template" label comes from though. |
|
Tested with a few different themes and with custom post types, works well. |
|
I updated the filtering logic, and now it's all done inside Thanks, everyone, for the feedback and testing ❤️ |
Mamaduka
force-pushed
the
fix/custom-templates-post-types
branch
from
22a4f61 to
c680bb1
Compare
TimothyBJacobs
previously requested changes
Oct 21, 2021
Introduces 'WP_Block_Template::$default' property
Mamaduka
force-pushed
the
fix/custom-templates-post-types
branch
from
c680bb1 to
9af8ab4
Compare
Mamaduka
dismissed
TimothyBJacobs’s stale review
I pushed the required changes.
vcanales
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Templates: Only include templates for the current post types * Exclude default templates when requesting templates for post type * Introduces `WP_Block_Template::$is_custom` property * Move filtering logic inside `gutenberg_get_block_templates` * Update collections params
7 tasks
youknowriad
reviewed
Dec 6, 2021
| if ( ! gutenberg_supports_block_templates() ) { | ||
| return $templates; | ||
| } | ||
|
|
||
| $block_templates = gutenberg_get_block_templates( array(), 'wp_template' ); | ||
| $block_templates = gutenberg_get_block_templates( array( 'post_type' => $post_type ), 'wp_template' ); |
There was a problem hiding this comment.
I think this change hasn't been backported properly into Core yet.
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates block templates loading logic only to include templates for the current post type. These post types can be defined using the
customTemplatessetting in the theme.json.Fixes #31704
How has this been tested?
update/templatesbranch.Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).