Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Add new Comment Reply Link block #35774

Merged
merged 11 commits into from
Oct 27, 2021
Merged

Block Library: Add new Comment Reply Link block #35774

merged 11 commits into from
Oct 27, 2021

Commits on Oct 27, 2021

  1. Comment Reply: Init block files

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    636fb71 View commit details
    Browse the repository at this point in the history

  2. Remove unexpected throw

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    e29eab0 View commit details
    Browse the repository at this point in the history

  3. Comment Reply: Render a clickable link 

    - It uses `get_comment_reply_link` to generate the link.
- That function already cover most of the cases, except comments depth.
    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7936f0d View commit details
    Browse the repository at this point in the history

  4. Comment Reply: Add style settings

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    4076bec View commit details
    Browse the repository at this point in the history

  5. Comment Reply: Create block fixture files

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    ab7d009 View commit details
    Browse the repository at this point in the history

  6. Comment Reply: Fix phpcs errors

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    15dbe89 View commit details
    Browse the repository at this point in the history

  7. Comment Reply: Fix some comments

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7ce5b48 View commit details
    Browse the repository at this point in the history

  8. Icons: Fix comment reply link

    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    8204dc2 View commit details
    Browse the repository at this point in the history

  9. Comment Reply: Change href in editor 

    Using `#comment-reply-pseudo-link` for consistency.
That pattern is being used in other blocks, e.g.
Post Comment Author or Post Comment Date
    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    d01d825 View commit details
    Browse the repository at this point in the history

  10. Comment Reply: Fix SSR for some cases 

    The cases are:
- The comment ID passed is invalid
- The comment doesn't have any parents
- There is no link to render
    @DAreRodz
    DAreRodz committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    676a954 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'trunk' into add/comment-reply-link

    @gziolo
    gziolo authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    cf48525 View commit details
    Browse the repository at this point in the history