-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Library: Add new Comment Reply Link block #35774
Merged
Merged
Commits on Oct 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 636fb71 - Browse repository at this point
Copy the full SHA 636fb71View commit details -
Configuration menu - View commit details
-
Copy full SHA for e29eab0 - Browse repository at this point
Copy the full SHA e29eab0View commit details -
Comment Reply: Render a clickable link
- It uses `get_comment_reply_link` to generate the link. - That function already cover most of the cases, except comments depth.
Configuration menu - View commit details
-
Copy full SHA for 7936f0d - Browse repository at this point
Copy the full SHA 7936f0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4076bec - Browse repository at this point
Copy the full SHA 4076becView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab7d009 - Browse repository at this point
Copy the full SHA ab7d009View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15dbe89 - Browse repository at this point
Copy the full SHA 15dbe89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ce5b48 - Browse repository at this point
Copy the full SHA 7ce5b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8204dc2 - Browse repository at this point
Copy the full SHA 8204dc2View commit details -
Comment Reply: Change href in editor
Using `#comment-reply-pseudo-link` for consistency. That pattern is being used in other blocks, e.g. Post Comment Author or Post Comment Date
Configuration menu - View commit details
-
Copy full SHA for d01d825 - Browse repository at this point
Copy the full SHA d01d825View commit details -
Comment Reply: Fix SSR for some cases
The cases are: - The comment ID passed is invalid - The comment doesn't have any parents - There is no link to render
Configuration menu - View commit details
-
Copy full SHA for 676a954 - Browse repository at this point
Copy the full SHA 676a954View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf48525 - Browse repository at this point
Copy the full SHA cf48525View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.