Global Settings: simplify logic to retrieve settings by editor #35437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
oandregal
force-pushed
the
update/clean-up-gs-settings
branch
from
22f4377 to
4c86a01
Compare
oandregal
commented
Oct 7, 2021
| $origin = 'user'; | ||
| } | ||
| $consolidated = WP_Theme_JSON_Resolver_Gutenberg::get_merged_data( $settings, $origin ); | ||
| $consolidated = WP_Theme_JSON_Resolver_Gutenberg::get_merged_data( $settings ); |
There was a problem hiding this comment.
There may be user data even if the theme does not have a theme.json, as per #35427 so we need to update user data lookup to the new logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #35424 and #35427
This PR simplifies the logic to load different settings per editor context.