Rich text/raw handling: add support for MathML #35005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Rich Text
|
Size Change: +310 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
dmsnell
reviewed
Aug 21, 2023
| @@ -134,6 +134,8 @@ export default function cleanNodeList( nodeList, doc, schema, inline ) { | |||
| } else if ( | |||
| node.parentNode && | |||
| node.parentNode.nodeName === 'BODY' && | |||
| // To do: figure out why this is needed. | |||
There was a problem hiding this comment.
is the TODO "figure out why this cleans/prunes MathML sub-trees by default" or is it something else?
| mn: { children: { '#text': {} } }, // Numeric literal. | ||
| mo: { children: { '#text': {} }, attributes: [ 'stretchy' ] }, // Operator. | ||
| ms: { children: { '#text': {} } }, // String literal. | ||
| mtext: { children: { '#text': {} } }, // Arbitrary text. |
There was a problem hiding this comment.
are we missing annotation-xml here?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it's not possible to paste MathML into Gutenberg. Tags will get stripped.
It is possible to insert it in HTML mode, but in visual mode the tags are not protected from editing.
This PR adds a schema for MathML to the raw handler and protects the
mathelement in rich text.MathML rendering is supported in Safari and Firefox, but unfortunately Chrome and other browsers don't render it properly (it's just rendered as inline text). The user can add the MathJax script on the front-end, which renders it properly across all browsers. The MathJax scripts detects the
mathelements and transforms them. In the future we could consider adding the script to core and load it if amathelement is detected on the page.Also worth nothing that the work being done here could also enable support for ruby elements, which are quite similar for rich text to handle.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).