Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Editable to have variable node name. #347

Merged
merged 6 commits into from
Apr 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion blocks/components/editable/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/**
* Internal dependencies
*/
import './style.scss';

export default class Editable extends wp.element.Component {
constructor() {
super( ...arguments );
Expand Down Expand Up @@ -70,6 +75,12 @@ export default class Editable extends wp.element.Component {
}

render() {
return <div ref={ this.bindNode } />;
const { tagName: Tag = 'div' } = this.props;

return (
<Tag
ref={ this.bindNode }
className="blocks-editable" />
);
}
}
3 changes: 3 additions & 0 deletions blocks/components/editable/style.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.blocks-editable:focus {
outline: none;
}
7 changes: 0 additions & 7 deletions editor/assets/stylesheets/main.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
@import './variables';
@import '../../header/style';
@import '../../header/mode-switcher/style';
@import '../../inserter/style';
@import '../../modes/text-editor/style';
@import '../../modes/visual-editor/style';

body.toplevel_page_gutenberg {
background: #fff;

Expand Down
3 changes: 2 additions & 1 deletion editor/blocks/text/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ wp.blocks.registerBlock( 'core/text', {
category: 'common',

attributes: {
value: html()
value: html( 'p' )
},

edit( { attributes, onChange } ) {
return (
<Editable
tagName="p"
value={ attributes.value }
onChange={ ( value ) => onChange( { value } ) }
/>
Expand Down
1 change: 1 addition & 0 deletions editor/header/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* Internal dependencies
*/
import './style.scss';
import ModeSwitcher from './mode-switcher';

function Header() {
Expand Down
1 change: 1 addition & 0 deletions editor/header/mode-switcher/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { connect } from 'react-redux';
/**
* Internal dependencies
*/
import './style.scss';
import Dashicon from '../../components/dashicon';

class ModeSwitcher extends wp.element.Component {
Expand Down
1 change: 1 addition & 0 deletions editor/inserter/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* Internal dependencies
*/
import './style.scss';
import Dashicon from '../components/dashicon';

function Inserter() {
Expand Down
5 changes: 5 additions & 0 deletions editor/modes/text-editor/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
import { connect } from 'react-redux';
import Textarea from 'react-textarea-autosize';

/**
* Internal dependencies
*/
import './style.scss';

function TextEditor( { html, onChange } ) {
const changeValue = ( event ) => {
onChange( event.target.value );
Expand Down
1 change: 1 addition & 0 deletions editor/modes/visual-editor/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { connect } from 'react-redux';
/**
* Internal dependencies
*/
import './style.scss';
import InserterButton from '../../inserter/button';
import VisualEditorBlock from './block';

Expand Down
4 changes: 3 additions & 1 deletion index.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function gutenberg_register_scripts() {
wp_register_script( 'wp-i18n', plugins_url( 'i18n/build/index.js', __FILE__ ) );
wp_register_script( 'wp-element', plugins_url( 'element/build/index.js', __FILE__ ), array( 'react', 'react-dom' ) );
wp_register_script( 'wp-blocks', plugins_url( 'blocks/build/index.js', __FILE__ ), array( 'wp-element', 'tinymce-nightly' ) );
wp_register_style( 'wp-blocks', plugins_url( 'blocks/build/style.css', __FILE__ ) );
}
add_action( 'init', 'gutenberg_register_scripts' );

Expand Down Expand Up @@ -206,7 +207,8 @@ function gutenberg_scripts_and_styles( $hook ) {
);
wp_enqueue_style(
'wp-editor',
plugins_url( 'editor/build/style.css', __FILE__ )
plugins_url( 'editor/build/style.css', __FILE__ ),
array( 'wp-blocks' )
);
}
add_action( 'admin_enqueue_scripts', 'gutenberg_scripts_and_styles' );
Expand Down
8 changes: 4 additions & 4 deletions languages/gutenberg.pot
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@ msgstr ""
msgid "Freeform"
msgstr ""

#: editor/header/mode-switcher/index.js:30
#: editor/header/mode-switcher/index.js:31
msgctxt "Name for the Text editor tab (formerly HTML)"
msgid "Text"
msgstr ""

#: editor/header/mode-switcher/index.js:29
#: editor/header/mode-switcher/index.js:30
msgid "Visual"
msgstr ""

#: editor/header/mode-switcher/index.js:43
#: editor/header/mode-switcher/index.js:44
msgid "Switch the editor mode"
msgstr ""

#: editor/inserter/button.js:31
msgid "Add a block"
msgstr ""

#: editor/inserter/index.js:39
#: editor/inserter/index.js:40
msgid "Search…"
msgstr ""
7 changes: 6 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ const config = {
{
loader: 'sass-loader',
query: {
includePaths: [ 'editor/assets/stylesheets' ],
data: '@import "variables";',
outputStyle: 'production' === process.env.NODE_ENV ?
'compressed' : 'nested'
}
Expand All @@ -65,7 +67,10 @@ const config = {
]
}
} )
]
],
stats: {
children: false
}
};

switch ( process.env.NODE_ENV ) {
Expand Down