-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate canUser resolver to thunks #34580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
force-pushed
the
update/migrate-canUser
branch
from
September 6, 2021 12:26
1aaa73e
to
883c314
Compare
adamziel
changed the base branch from
update/resolvers-migration-next-step
to
trunk
September 6, 2021 12:26
jsnajdr
force-pushed
the
update/migrate-canUser
branch
from
September 7, 2021 06:04
883c314
to
01f53eb
Compare
Size Change: +1.19 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
update/migrate-canUser
branch
from
September 7, 2021 08:05
01f53eb
to
3e21daf
Compare
jsnajdr
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Core data
/packages/core-data
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the thunks support added in #27276 and refactors just the parts of core-data required to make the
canUser
work (this PR is a minimal viable subset of #28389 with unit tests adjusted).Test plan:
Confirm the automated tests pass