Migrate getEntityRecords resolver to thunks #34578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Sep 6, 2021
| // Provide entities and acquire lock | ||
| fulfillment.next( ENTITIES ); | ||
| // Provide response | ||
| triggerFetch.mockImplementation( () => POST_TYPES ); |
There was a problem hiding this comment.
.mockResolvedValue( POST_TYPES )
| const p = new Promise( ( resolve ) => setTimeout( resolve ) ); | ||
| jest.runAllTimers(); | ||
| await p; | ||
| } |
There was a problem hiding this comment.
I have a hard time understanding what is this integration test testing. Instead of calling jest.runAllTimers() all the time, can we use jest.useRealTimers() and properly await a relevant promise before asserting some fact? That's a suggestion for a rewrite in another PR. For now, hacking our way through the test is probably OK.
jsnajdr
requested changes
Sep 6, 2021
adamziel
force-pushed
the
update/migrate-getEntityRecordsToThunks
branch
from
d7a034f to
0bc4da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of the thunks support added in #27276 and refactors just the parts of core-data required to make the
getEntityRecordswork (this PR is a minimal viable subset of #28389).Test plan:
Confirm the automated tests pass
blog titleblock, edit it, save the post and related entities