Update roundClamp to match HTML number input stepping behavior #34566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
7 tasks
ciampo
added
[Feature] UI Components
stokesman
force-pushed
the
update/roundClamp-parity-with-html
branch
from
380d388 to
0d12c6a
Compare
6 tasks
8 tasks
- Rounds to steps starting from min - Uses rounding precision determined by the greater of min or step - If max is not on a step, uses the closest step less than max
stokesman
force-pushed
the
update/roundClamp-parity-with-html
branch
from
f08bd34 to
701b64d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, it's easy to create a
NumberControlthat steps (using keyboard arrow keys or dragging) to invalid values. This is in contrast to the Standard HTML<input type="number"/>which does not step to invalid values. This PR modifies ourroundClamputility function in order to have it avoid invalid values:minminorstepmaxis not a valid step, uses the closest step less than itroundClampis also used byFocalPointPickerbut its usage is unaffected by these changes.How has this been tested?
Manually with
NumberControlusing various combinations ofmin,maxandstepand comparing the behavior of a plain<input type="number"/>with the same combinations (in Chromium). Unit tests old and new ones written to cover new behavior in this PR.Screenshots
Steps starting from
minRounding to the greater precision of either
minorstepTypes of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).