Remove some low impact APIs that were deprecated on WP 5.3 #34537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
mtias,
gziolo,
ciampo,
ellatrix,
annezazu and
priethor
youknowriad
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: -435 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Should we move it to the post editor so it isn't included on other screens? One thing I'm not sure about is how all those screen-specific blocks would work when saved inside the Reusable block. I guess it's something that should be discussed separately anyway.
Should we take one more step and remove all the logic but keep those functions defined with deprecations for one more major release? In general, it sounds like a good plan. |
gziolo
added
the
Backwards Compatibility
I guess you're talking about the core/editor to core/block-editor here, right? I'm not sure yet, there's a lot, so I felt it's a bit too soon for these to break. |
I think I misguided you, I was referring to |
|
Oh for these, I was pretty confident because I checked wpdirectory and also because they really seem like "core" things and things plugin authors would very rarely use. |
ciampo
reviewed
Sep 3, 2021
There was a problem hiding this comment.
Thank you for the cleanup, Riad! I mostly had a look at the changes in @wordpress/components.
onClickOutsideforPopovercomponent: the component still works without it, it might not close when you click outside it.
From a quick look at the code, I don't think that before this PR, clicking outside the popover would close the popover itself — maybe I'm missing something? (Or did you mean that the modal could have been with some 3rd party code in the onClickOutside callback?)
Also, I can still see traces of the menuLabel and position deprecated props in the React Native version of DropdownMenu
👍 from me. These have been properly marked as deprecated for a while. |
youknowriad
force-pushed
the
remove/deprecated-apis-in-wp-53
branch
from
43b4c30
to
4bebc09
Compare
|
I finally got back to this PR and remove the removed props from the native code. I think it's ready. |
youknowriad
added
the
Needs Dev Note
youknowriad
force-pushed
the
remove/deprecated-apis-in-wp-53
branch
from
4bebc09
to
140b1f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some old APIs that have a low impact and that were deprecated in 5.3.
I also removed some selectors and actions from the 'core/editor' store after checking that it has no impact based on a wpdirectory.net
There are still other APIs that were deprecated on 5.3 that I decided against removing for now because of their potential impact (we could consider removal in future WP major versions):
wp.editortowp.blockEditorfor some components, selectors and actionswp.components.ServerSideRendercomponent.What do you think of my arbitrations here?