Border Controls: Display color indicator and check selected color #34467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacimc
added
the
[Feature] Design Tools
|
Size Change: +2.79 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
stacimc
force-pushed
the
fix/border-panel-color-picker
branch
from
a36f938 to
9addeb9
Compare
7 tasks
andrewserong
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Thanks for fixing this up @stacimc, this is testing nicely! 🎉
| Before | After |
|---|---|
 |
 |
✅ Color indicator and check mark are working for border color with this applied
✅ Works for both named color and custom color
✅ Initial state when switching between blocks appears to be correct
✅ Works in the site editor, too
LGTM!
Mamaduka
reviewed
Sep 7, 2021
|
I think we can merge this PR. All feedback got addressed, and @andrewserong did an amazing job testing it. |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The border panel was using an incorrect prop name, so the ColorGradientControl would not display the color indicator for the selected color, or the check mark for a selected preset. This updates the prop name and makes sure to handle custom as well as preset colors. (See screenshots)
How has this been tested?
Manually. I tested on trunk, and also tested after rebasing on #33743 which will switch the border panel to use the new ToolsPanel.
Screenshots
Before:
After:
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).