Gallery Block : Remove IE specific CSS hacks #34372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: -406 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
This is testing nicely for me @glendaviesnz!
✅ Tested across Safari, Chrome, FF, and Edge on desktop Mac, and Safari and Chrome on iOS.
No issues with the affected CSS. I did notice that the media library was challenging to navigate on mobile, and also that it's difficult to move from an image block to the parent gallery block in the mobile web editor, but these are outside the scope of this PR of course!
LGTM, but might be worth getting another pair of eyes for testing, too, to cover possibly an Android phone?
|
Thanks @andrewserong I just retested with Chrome on Android phone and it all looks good, so I will go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #33483
Testing