Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Tagline: add font weight support #33983

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Site Tagline: add font weight support #33983

merged 1 commit into from
Aug 12, 2021

Conversation

jffng
Copy link
Contributor

@jffng jffng commented Aug 10, 2021

Description

This PR adds font weight support to the site tagline block.

How has this been tested?

  • Activate an FSE theme
  • Add a site tagline
  • Verify you can change the font weight in the block inspector

Screenshots

Screen Shot 2021-08-10 at 1 52 38 PM

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@jffng jffng added the [Block] Site Tagline Affects the Site Tagline Block label Aug 10, 2021
@jffng jffng requested a review from ajitbohra as a code owner August 10, 2021 17:55
@jffng jffng mentioned this pull request Aug 10, 2021
Merged
jorgefilipecosta
jorgefilipecosta approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Aug 12, 2021
@scruffian scruffian merged commit 29d286f into trunk Aug 12, 2021
@scruffian scruffian deleted the add/site-tagline-fontweight branch August 12, 2021 12:40
@github-actions github-actions bot added this to the Gutenberg 11.4 milestone Aug 12, 2021
@mtias mtias mentioned this pull request Aug 12, 2021
Open
65 tasks
@mtias mtias mentioned this pull request Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@mtias mtias mtias approved these changes

@scruffian scruffian Awaiting requested review from scruffian

@MaggieCabrera MaggieCabrera Awaiting requested review from MaggieCabrera

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@jffng jffng

Labels
[Block] Site Tagline Affects the Site Tagline Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
Design Tools Project
Status: ✅ Done
Milestone
Gutenberg 11.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jffng @mtias @jorgefilipecosta @scruffian