Components: use the __unsafe_useEmotionCache in the useCx hook
#33982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
commented
Aug 10, 2021
Comment on lines
46
to
50
| if ( cache === null ) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
Not sure if there's a better return value in case cache is null
There was a problem hiding this comment.
If the cache is null I think we should throw an error on line 43. It would indicate that useCx is being called outside of an Emotion Cache Context which is not valid, right?
There was a problem hiding this comment.
Done in 40bd650 (#33982).
|
Size Change: -60 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Aug 10, 2021
Comment on lines
46
to
50
| if ( cache === null ) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
If the cache is null I think we should throw an error on line 43. It would indicate that useCx is being called outside of an Emotion Cache Context which is not valid, right?
ciampo
force-pushed
the
update/emotion-use-emotion-cache
branch
from
a59b50b to
40bd650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent change in Emotion exposed the
__unsafe_useEmotionCache()hook.This PR updates the package versions of
@emotion/reactand@emotion/cacheand uses this newly exposed function in theuseCxhook, instead of exposing the privateCacheProvider._contextvariable directly.How has this been tested?
useCxStorybook story)Screenshots
N/A
Types of changes
Refactor
Checklist:
*.native.jsfiles for terms that need renaming or removal).