Site Editor: Add error boundary #33921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
Mamaduka
commented
Aug 6, 2021
Comment on lines
+30
to
+32
| static getDerivedStateFromError( error ) { | ||
| return { error }; | ||
| } |
There was a problem hiding this comment.
I noticed that other ErrorBoundary components use componentDidCatch for fallback rendering while React documentation recommends using getDerivedStateFromError.
Is there a special reason we want to use the componentDidCatch lifecycle method?
|
Size Change: +318 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
add/site-editor-error-boundary
branch
from
36b384d to
e1795e4
Compare
|
It looks like adding an error boundary causes the "Performance Tests" to fail. |
|
It looks like moving the |
youknowriad
reviewed
Aug 9, 2021
| @@ -179,8 +180,6 @@ function Editor( { initialSettings } ) { | |||
| return ( | |||
| <> | |||
| <URLQueryController /> | |||
| <FullscreenMode isActive /> | |||
| <UnsavedChangesWarning /> | |||
There was a problem hiding this comment.
Do you know if moving these two components has any impact?
Other than that, this is looking good.
There was a problem hiding this comment.
I tested, and I wasn't able to spot any.
The is-full-screen class is applied to the body, and an "unsaved changes warning" is triggered if I try to reload the page.
youknowriad
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds error boundary to the Site Editor. The fallback will render a warning message with actions to "Attempt Recovery" or "Copy Error." It's similar to other editor error boundaries.
Initially, I was planning to reuse the
ErrorBoundarycomponent from the editor package, but the "Copy Post Text" doesn't make sense in the context of site editing.I also moved the following components near the InterfaceSkeleton -
URLQueryController,FullscreenModeandUnsavedChangesWarning.Fixes #33899.
How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).