Template Part placeholder - Add title step to creation flow. #33703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.51 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
Addison-Stavlo
added
[Block] Template Part
Addison-Stavlo
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
creativecoder,
david-szabo97,
ntsekouras and
annezazu
Right 🤔 . Its moving to the patterns setup component, and since there are no patterns registered here that forwards it to the 'create blank' step of that component which triggers creation but doesn't render anything on the page.... Now after talking it out I realize we can make that step render a placeholder as well. 🤣 That seems like something we should do.
Good catch! thanks for taking a look @david-szabo97 😁 |
|
Updated so the 'create blank' step renders a placeholder, and the 'create' button in the title naming step disables if the title is blank.
I think I may still need to follow up on some minor e2e test adjustments to accommodate the extra step in creation. |
|
Changes looking good! Last piece of the puzzle is the e2e test 😄 |
Success |
Addison-Stavlo
deleted the
add/title-step-to-template-part-creation-from-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to discussion on #29950 - Adds a title step to the creation flow from the Template Part placeholder. Here we prompt the user with a modal (similar to the "make template part" flow from the block settings ellipsis menu) to change the name of the title from "Untitled Template Part". If the modal is cancelled, we revert to the placeholder and the template part is not created.
How has this been tested?
With FSE enabled, test the following in both the Site and Post editor:
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).