Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Avoid rendering duplicate elements stylesheet #33680

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Global Styles: Avoid rendering duplicate elements stylesheet #33680

merged 1 commit into from
Jul 28, 2021

Conversation

Mamaduka
Copy link
Member

Description

Removes WP Core filter for "elements support" to avoid rendering duplicate stylesheet.

Fixes #33669.

Similar PRs - #33005 and #33233.

How has this been tested?

  1. Add the Paragraph block.
  2. Select text and add a link.
  3. Set link color for the paragraph.
  4. Save post.
  5. On the front-end, WP shouldn't render duplicated stylesheet for link color.

Screenshots

CleanShot 2021-07-26 at 10 58 36

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Jul 26, 2021
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jul 26, 2021
youknowriad
youknowriad approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@Mamaduka Mamaduka merged commit 14020d0 into trunk Jul 28, 2021
@Mamaduka Mamaduka deleted the fix/duplicate-elements-stylesheet branch July 28, 2021 10:08
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees

@Mamaduka Mamaduka

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 11.3
Development

Successfully merging this pull request may close these issues.

Link color: multiple wp-elements-* classes and duplicate style elements
2 participants
@Mamaduka @youknowriad