Tools: Add depth to git fetch in npm publishing #33595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
npm Packages
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All commands controlled through
./bin/plugin/cli.jsuse a shallow clone of git repository:gutenberg/bin/plugin/lib/git.js
Lines 22 to 25 in 4ee463b
In general, it's a good thing as it makes the download size necessary for commands to work much smaller. However, in the case of npm publishing, we need a bit of git history for the branch used in the release process so Lerna could do its stuff. This PR add a
get fetch --depth=100call to npm publishing commands so Lerna could operate correctly. In practice, it allows us to publish only those packages that were modified. Without this change, it tried to publish all available packages in most of the cases.How has this been tested?
I published a bugfix release with
./bin/plugin/cli.js npm-bugifxand I can confirm that only two packages were published - as expected:5bac0d7