Featured Image: Allow authors to select images uploaded by other users #33567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Post Featured Image
|
Size Change: +12 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
ntsekouras
reviewed
Jul 20, 2021
ntsekouras
approved these changes
Jul 20, 2021
|
Two years of campaigning has finally concluded. If WordPress does not give me credit for the time I've spent to push this up... @Mamaduka Endless high-fives for resolving this issue. |
gziolo
reviewed
Aug 6, 2021
| @@ -44,7 +44,13 @@ function PostFeaturedImageDisplay( { | |||
| ); | |||
| const media = useSelect( | |||
| ( select ) => | |||
| featuredImage && select( coreStore ).getMedia( featuredImage ), | |||
| featuredImage && | |||
| select( coreStore ).getEntityRecord( | |||
There was a problem hiding this comment.
@youknowriad, is it possible to pass additional params to getMedia and other methods automatically generated from entities? One thing that surprises me is that I see getEntityRecord used so often despite all these shorthand methods available:
There was a problem hiding this comment.
@Mamaduka, it's optional. I was rather sharing a general thought about the surprising popularity of more verbose getEntityRecord.
There was a problem hiding this comment.
@gziolo, I also kinda like getMedia( mediaId, { context: 'view' } ) more 😄 So follow-up PR won't be a problem.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes the issue when users with the Author role couldn't select images uploaded by other users.
The media entity is only requested for display. Therefore, I think it makes sense to change the request
contextto theviewargument.Fixes #18510.
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).