Update button block corner radius test to px #33562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +74 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
fluiddot
reviewed
Jul 21, 2021
packages/components/src/mobile/bottom-sheet/stepper-cell/stepper.android.js
Outdated
Show resolved
Hide resolved
fluiddot
reviewed
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Button block "Border Radius" setting used to use a unit of
%but now it defaults topxand can support other units (em,rem, and%). So it makes sense to update the test to use the default unit of%, which is likely the most common.How has this been tested?
Screenshots
Not applicable.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).