Spacer: change props override order, split types
#33555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
|
Size Change: +16 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Jul 19, 2021
ciampo
changed the title
Spacer: change props override order, move types to separate fileSpacer: change props override order, split types
|
@ciampo Would be great if you could add one of the '[Type]' labels (usually enhancement or bug) to the Component System PRs. These affect how the changes are categorized in the changelog for Gutenberg releases—at the moment whoever compiles the changelog has to go through and manually check what each PR was when the label is missing, so this would save a lot of work. |
Hey @talldan, thank you for flagging this. I've added a label, sorry if I didn't include it before! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks a few minor improvements to the
<Spacer />component that were part of #33055 and didn't get merged when the original PR got closed:How has this been tested?
To test those changes:
npm run storybook:devlocally, visit theSpacerstory and play around with the knobsScreenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).